Skip to content
GitLab

Fix crash with disabled global stats.

Merged Abhinav Anil Sharma requested to merge iX-disabled-stats-assert into master

When global stats are disabled, we do not keep fragment count. This causes us to try triggering a reset even when reset_at_fragment_count is zero.

Failure without this fix: In debug build:

 ./bin64/drrun -no_global_stats  -- suite/tests/bin/allasm_scattergather

<Application dynamorio/suite/tests/bin/allasm_scattergather (1281891).  Internal Error: DynamoRIO debug check failure: dynamorio/core/fragment.c:2376 INTERNAL_OPTION(reset_at_fragment_count) != 0

In release build:

 ./bin64/drrun -no_global_rstats  -- suite/tests/bin/allasm_scattergather

<Goes into a reset infinite loop>

Also adds a long suite test that runs the simple app without global stats. Tested locally using

cmake -DDEBUG=ON   -DBUILD_TESTS=ON -DRUN_LONG_SUITE=ON ..