Increase the width of the `record#` and `instr#` column views in drmemtrace
Created by: lihasgupta
Is your feature request related to a problem? Please describe.
In the trace view the column widths are set to 9 characters. Very often this we encounter record#
and instr#
fields that have more characters than this. This makes interpreting the output difficult. An example view like this is:
<record#> <instr#>: T<tid> <record details>
------------------------------------------------------------
43564449812929999994: T442476 read 4 byte(s) @ 0x00002407b00887a8 by PC 0x0000560fd9e5b99e
43564449822929999995: T442476 ifetch 5 byte(s) @ 0x0000560fd9e5b9a3 be 00 4e 00 00 mov $0x00004e00 -> %esi
43564449832929999996: T442476 ifetch 2 byte(s) @ 0x0000560fd9e5b9a8 31 d2 xor %edx %edx -> %edx
In this example it is very difficult to tell when the record#
field ends and the instr#
field begins. The width of these columns should be increased.
Describe the solution you'd like We should increase the width of these columns, there are two options for this:
- Increase the width dynamically by looking at the size of inputs. This may however be problematic if the view crosses a digit boundary as columns will not line up.
- Increase the width of these columns to 12 characters. This will give us a buffer for a lot more traces and will make this problem less prevalent.
I personally believe going with solution 2 will help make the viewer much more usable and will reduce the prevalence of this issue significantly. It is relatively easy to implement and the tool will still remain intuitive to use because columns will line up.