suite failures on Win10 1709
I upgraded the machine running the CDash suite to Win10 1709 and it hits a number of failures:
debug-internal-32: 233 tests passed, **** 12 tests failed: ****
code_api|win32.rebased
code_api|win32.multisec
code_api|win32.hooker-secur32
code_api|security-win32.except-execution
code_api|win32.tls
code_api|win32.reload-newaddr
code_api|client.thread
code_api|client.loader
code_api|client.winxfer
code_api|client.pcache-use => Application D:\derek\dr\build_suite\build_debug-internal-32\suite\tests\bin\client.pcache.exe (12228). Internal Error: DynamoRIO debug check failure: D:\derek\dr\git\src\core\perscache.c:1603 tag != NULL || (instr_opcode_valid(instr) instr_is_cbr(instr))
code_api|client.nudge_ex => Application D:\derek\dr\build_suite\build_debug-internal-32\suite\tests\bin\client.nudge_ex.exe (13224). Internal Error: DynamoRIO debug check failure: D:\derek\dr\git\src\core\nudge.c:523 hthread != INVALID_HANDLE_VALUE
code_api|client.drx-test => Application D:\derek\dr\build_suite\build_debug-internal-32\suite\tests\bin\client.drx-test.exe (12836). Internal Error: DynamoRIO debug check failure: D:\derek\dr\git\src\core\nudge.c:523 hthread != INVALID_HANDLE_VALUE
debug-internal-64: 211 tests passed, **** 8 tests failed: ****
code_api|win32.multisec
code_api|win32.rebased
code_api|win32.mixedmode_late
code_api|client.loader
code_api|client.fibers
code_api|client.winxfer
code_api|client.pcache-use => Application D:\derek\dr\build_suite\build_debug-internal-64\suite\tests\bin\client.pcache.exe (13000). Internal Error: DynamoRIO debug check failure: D:\derek\dr\git\src\core\perscache.c:1603 tag != NULL || (instr_opcode_valid(instr) instr_is_cbr(instr))
code_api|client.nudge_ex => Application D:\derek\dr\build_suite\build_debug-internal-64\suite\tests\bin\client.nudge_ex.exe (11396). Internal Error: DynamoRIO debug check failure: D:\derek\dr\git\src\core\vmareas.c:8207 !ok || !TEST(MEMPROT_WRITE, prot2) || TEST(FRAG_SELFMOD_SANDBOXED, *flags) || !INTERNAL_OPTION(hw_cache_consistency)
release-external-32: build successful; no tests for this build
release-external-64: build successful; no tests for this build
vps-debug-internal-32: build successful; no tests for this build
For nudge_ex: xref #1167 (closed) and https://github.com/DynamoRIO/dynamorio/issues/2145#issuecomment-280178636 and #1432 (closed)
#1432 (closed) also intersects with multisec and rebased