Merged
requested to merge github/fork/f3ndot/ocid-download-and-recheck-improvements into development
Created by: f3ndot
Agreements
-
I have reviewed and accepted the guidelines for contributing to this project. -
I have reviewed and closely followed the Style Guide for this Android app.
Overview
This should fix #558 (closed). I verified the fix in my local area by:
- Clearing the OCID database so AIMSICD is in a "vanilla" state and going to an area where I'm connected to a cell tower known to OCID.
- Observing that I'm getting a MEDIUM/yellow since I have no entries in OCID database to compare against
- Download the BTS data from OCID from the sidebar
- Observe that the notification has changed from MEDIUM/yellow to OK/green once the successful download toast displays
Specifically resolved issues:
-
CellTracker#setNotification()
now always fires whenCellTracker#compareLac(CellLocation)
is called since recovering from a dangerous state should update the notification. Aka from MEDIUM to OK -
RequestTask
provides a listener interface for completion callbacks soHelpers#getOpenCellData(...)
fires OCID check on success - Timeout for OCID download increased from default 10 seconds to 60 seconds, since the OCID API is slow as hell.
- If OCID API times out, we display that to the user as a special error message.
The listener callback interface is a bit crude, but is better than having RequestTask do too much.
Classification
-
Bugfix (non-breaking change which fixes an existing issue) -
New feature (non-breaking change which adds functionality) -
Refactor (restructuring of existing code without changing its external functionality) -
Breaking change (fix or feature that would cause existing functionality to not work as expected)
References
See #558 (closed) for feature request. This PR supersedes #793.
Screenshots
N/A