Created by: smarek
So, what was done:
- Removed unused class-global fields
- Removed, WTF, code
new Thread().sleep(500);
- Rewritten implementation of reading String lines out of buffer, including one more local temporary variable
- Fixed author javadoc tag
- Replaced first level of
for-loop
incheckForSilentSms
withforeach
- Removed pointless calls
toString()
in context like thisDETECTION_PHONENUM_SMS_DATA[2].toString()
(where DETECTION_PHONENUM_SMS_DATA is array of Strings) Some encoding sincerely occured on-the-fly, hope you don't mind. #615 (closed) discussion points are imho fixed by this PR #537 pointed out that the problem with performance is in string retrieval/parsing/checking, I agree and we should imho migrate the code over to regexp declarations, and I'm worried we do not now correctly handle situations on border of string stream (where detection would fail because the data are incorrectly splitted by newline character)